Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subs): Avoid modifying a match that has already been altered. #147

Merged
merged 3 commits into from
Jan 5, 2024
Merged

fix(subs): Avoid modifying a match that has already been altered. #147

merged 3 commits into from
Jan 5, 2024

Conversation

johmsalas
Copy link
Owner

@johmsalas johmsalas commented Jan 5, 2024 •
edited
Loading

Fixes #142

@johmsalas johmsalas linked an issue Jan 5, 2024 that may be closed by this pull request
Subs not working when Origin is a substring of Destination #142
Closed
@johmsalas johmsalas mentioned this pull request Jan 5, 2024
Closed
@johmsalas johmsalas marked this pull request as ready for review January 5, 2024 03:57
@johmsalas johmsalas changed the title test(subs): Added test when Subs replaces a string and the replacement ends with the replaced string fix(subs): Avoid modifing already modified match Jan 5, 2024
@johmsalas johmsalas changed the title fix(subs): Avoid modifing already modified match fix(subs): Avoid modifying a match that has already been altered. Jan 5, 2024
peterfication
peterfication approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@peterfication peterfication left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and easy adaption 👌😊

@johmsalas
Copy link
Owner Author

Got lucky. Was trying a more classic solution and it was just too complicated.

Thanks for reviewing :)

@johmsalas johmsalas merged commit b812d89 into main Jan 5, 2024
6 checks passed
@johmsalas johmsalas deleted the 142-subs-not-working-when-origin-is-a-substring-of-destination branch January 5, 2024 12:36
@johmsalas johmsalas mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterfication peterfication peterfication approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subs not working when Origin is a substring of Destination
2 participants
@johmsalas @peterfication